Re: [PATCH v2 0/2] arm64: dts: qcom: eliza-evk: Enable PCIe0 and PCIe1 with M.2 and TC9563 switch
From: Bjorn Andersson
Date: Wed Jul 08 2026 - 11:56:09 EST
On Wed, Jul 08, 2026 at 11:47:15AM +0530, Krishna Chaitanya Chundru wrote:
> This series enables PCIe for the Eliza EVK board (CQS SoM on EVK carrier).
>
> The Eliza EVK exposes two PCIe ports:
>
> - PCIe0 drives an M.2 E key connector. The 3.3V supply is GPIO-controlled
> via a TCA9538 I/O expander on I2C4. The slot hosts a WLAN module
> (connected over PCIe) and a Bluetooth device (connected over UART5),
> modelled with the pcie-m2-e-connector binding.
>
> - PCIe1 (8GT/s x2) connects to a Toshiba TC9563 PCIe switch, whose
> management interface sits on I2C4 (address 0x77). The TC9563 RESX# and
> PERST# lines are OR-ed internally; reset is driven via a TLMM GPIO on
> the RESX# pin. The iommu-map covers all downstream switch ports
> (SID range 0x1400-0x1408).
>
> The M.2 WLAN module carries a Qualcomm QCC2072 Bluetooth chip. A device-ID
> entry is added to the M.2 power sequencer so the serdev node for the BT
> UART interface is created on PCI enumeration.
>
> Bluetooth is enabled with this patch https://lore.kernel.org/all/20260529175822.3366535-1-yepuri.siddu@xxxxxxxxxxxxxxxx/
>
> This seris Depends-on:
> https://lore.kernel.org/all/20260610-eliza_dt-v1-1-7bb72b75fc5b@xxxxxxxxxxxxxxxx/
Why send this patch, when this dependency is known bad - when would I
ever be able to merge this patch?
And why are you sending separate series concurrently with dependencies
between them!? It's one thing to send patches saying "I depend on
someone else's completely unrelated work", but saying "here's a random
bunch of tangled patches, good luck everyone!" is not okay.
I expect all three patches to be rebased and send in one series that I
can just click "Submit" on next time.
Thanks,
Bjorn
> https://lore.kernel.org/all/20260630-eliza-dts-qcs-evk-v4-3-18cbbdba6e7e@xxxxxxxxxxxxxxxx/
> https://lore.kernel.org/all/20260630-dts-qcom-eliza-mtp-evk-add-pmics-v1-1-f4f320f7c88b@xxxxxxxxxxxxxxxx/
>
> Signed-off-by: Krishna Chaitanya Chundru <krishna.chundru@xxxxxxxxxxxxxxxx>
> ---
> Changes in v2:
> - Drop patch 3, as this is already applied
> - Rebase on top of https://lore.kernel.org/all/20260708055017.A90C91F000E9@xxxxxxxxxxxxxxx/
> and remove pincntrl as pincntrl is added in the eliza.dtsi patch and also remove
> pinctrl for resx as this is covered in pcie1_default_state as perst gpio.
> - Link to v1: https://patch.msgid.link/20260703-eliza_evk-v1-0-7624440bd76d@xxxxxxxxxxxxxxxx
>
> To: Bjorn Andersson <andersson@xxxxxxxxxx>
> To: Konrad Dybcio <konradybcio@xxxxxxxxxx>
> To: Rob Herring <robh@xxxxxxxxxx>
> To: Krzysztof Kozlowski <krzk+dt@xxxxxxxxxx>
> To: Conor Dooley <conor+dt@xxxxxxxxxx>
> Cc: linux-arm-msm@xxxxxxxxxxxxxxx
> Cc: devicetree@xxxxxxxxxxxxxxx
> Cc: linux-kernel@xxxxxxxxxxxxxxx
>
> ---
> Krishna Chaitanya Chundru (2):
> arm64: dts: qcom: eliza-evk: Add PCIe0 with M.2 E key connector
> arm64: dts: qcom: eliza-evk: Add PCIe1 with TC9563 PCIe switch
>
> arch/arm64/boot/dts/qcom/eliza-evk.dtsi | 228 ++++++++++++++++++++++++++++++++
> arch/arm64/boot/dts/qcom/eliza.dtsi | 2 +
> 2 files changed, 230 insertions(+)
> ---
> base-commit: dc59e4fea9d83f03bad6bddf3fa2e52491777482
> change-id: 20260629-eliza_evk-6f30686b161f
> prerequisite-message-id: <20260708-eliza_dt-v2-1-e6281da26408@xxxxxxxxxxxxxxxx>
> prerequisite-patch-id: 7654ff4f899ac0094a2e791e7f208998fcc7d5fa
> prerequisite-patch-id: 9e10dfbe360941cdac0300aaf163149755952f9f
> prerequisite-patch-id: fecce0170351baf00cbe8f6b302d1def4d99bbfc
> prerequisite-patch-id: 97cd6cb495fdd198f6de7fbe45ef32e4a638ec9c
> prerequisite-message-id: <20260630-dts-qcom-eliza-mtp-evk-add-pmics-v1-1-f4f320f7c88b@xxxxxxxxxxxxxxxx>
> prerequisite-patch-id: f3615b5c1e2222a2491f862a7fba3994058ecc53
>
> Best regards,
> --
> Krishna Chaitanya Chundru <krishna.chundru@xxxxxxxxxxxxxxxx>
>