Re: [patch 11/18] seccomp, treewide: Rename and convert __secure_computing() to return boolean

From: Oleg Nesterov

Date: Wed Jul 08 2026 - 12:06:00 EST


On 07/08, Thomas Gleixner wrote:
>
> On Wed, Jul 08 2026 at 09:43, Jinjie Ruan wrote:
> >
> > The return value of __seccomp_filter is checked in the wrong way, check
> > -1 should be replaced with check false, maybe:
> >
> > - if (__seccomp_filter(this_syscall, true))
> > - return -1;
> > + if (!__seccomp_filter(this_syscall, true))
> > + return false;

Or simply

return __seccomp_filter(this_syscall, true);

and remove "return true" below ?

Either way, I personally like this change, I was always confused by these -1's.

Acked-by: Oleg Nesterov <oleg@xxxxxxxxxx>