Re: [PATCH] pmdomain: qcom: rpmhpd: Sort table entries by index name

From: Ulf Hansson

Date: Wed Jul 08 2026 - 12:25:10 EST


On Thu, Jun 11, 2026 at 10:52 AM Krzysztof Kozlowski
<krzysztof.kozlowski@xxxxxxxxxxxxxxxx> wrote:
>
> List of power domains in arrays of 'struct rpmhpd' are sorted according
> to index name (the define, e.g. RPMHPD_MX), not by actual numerical
> value. Fix few sorting mistakes, so comparing the tables between
> different devices will be easier. No functional impact - same binary.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxxxxx>

Applied for next, thanks!

Kind regards
Uffe


> ---
> drivers/pmdomain/qcom/rpmhpd.c | 24 ++++++++++++------------
> 1 file changed, 12 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/pmdomain/qcom/rpmhpd.c b/drivers/pmdomain/qcom/rpmhpd.c
> index 63120e703923..c12127d8e8ae 100644
> --- a/drivers/pmdomain/qcom/rpmhpd.c
> +++ b/drivers/pmdomain/qcom/rpmhpd.c
> @@ -305,10 +305,10 @@ static struct rpmhpd *sa8775p_rpmhpds[] = {
> [SA8775P_LMX] = &lmx,
> [SA8775P_MMCX] = &mmcx,
> [SA8775P_MMCX_AO] = &mmcx_ao,
> - [SA8775P_MXC] = &mxc,
> - [SA8775P_MXC_AO] = &mxc_ao,
> [SA8775P_MX] = &mx,
> [SA8775P_MX_AO] = &mx_ao,
> + [SA8775P_MXC] = &mxc,
> + [SA8775P_MXC_AO] = &mxc_ao,
> [SA8775P_NSP0] = &nsp0,
> [SA8775P_NSP1] = &nsp1,
> };
> @@ -325,10 +325,10 @@ static struct rpmhpd *nord_rpmhpds[] = {
> [RPMHPD_EBI] = &ebi,
> [RPMHPD_GFX] = &gfx,
> [RPMHPD_GFX1] = &gfx1,
> - [RPMHPD_MX] = &mx,
> - [RPMHPD_MX_AO] = &mx_ao,
> [RPMHPD_MMCX] = &mmcx,
> [RPMHPD_MMCX_AO] = &mmcx_ao,
> + [RPMHPD_MX] = &mx,
> + [RPMHPD_MX_AO] = &mx_ao,
> [RPMHPD_MXC] = &mxc,
> [RPMHPD_MXC_AO] = &mxc_ao,
> [RPMHPD_NSP0] = &nsp0,
> @@ -480,9 +480,9 @@ static struct rpmhpd *sm7150_rpmhpds[] = {
> [RPMHPD_GFX] = &gfx,
> [RPMHPD_LCX] = &lcx,
> [RPMHPD_LMX] = &lmx,
> + [RPMHPD_MSS] = &mss,
> [RPMHPD_MX] = &mx,
> [RPMHPD_MX_AO] = &mx_ao,
> - [RPMHPD_MSS] = &mss,
> };
>
> static const struct rpmhpd_desc sm7150_desc = {
> @@ -698,11 +698,11 @@ static struct rpmhpd *hawi_rpmhpds[] = {
> [RPMHPD_LMX] = &lmx,
> [RPMHPD_MMCX] = &mmcx,
> [RPMHPD_MMCX_AO] = &mmcx_ao,
> + [RPMHPD_MSS] = &mss,
> [RPMHPD_MX] = &mx,
> [RPMHPD_MX_AO] = &mx_ao,
> [RPMHPD_MXC] = &mxc,
> [RPMHPD_MXC_AO] = &mxc_ao,
> - [RPMHPD_MSS] = &mss,
> [RPMHPD_NSP] = &nsp,
> [RPMHPD_NSP2] = &nsp2,
> };
> @@ -809,18 +809,18 @@ static struct rpmhpd *glymur_rpmhpds[] = {
> [RPMHPD_CX_AO] = &cx_ao,
> [RPMHPD_EBI] = &ebi,
> [RPMHPD_GFX] = &gfx,
> + [RPMHPD_GMXC] = &gmxc,
> [RPMHPD_LCX] = &lcx,
> [RPMHPD_LMX] = &lmx,
> [RPMHPD_MMCX] = &mmcx,
> [RPMHPD_MMCX_AO] = &mmcx_ao,
> + [RPMHPD_MSS] = &mss,
> [RPMHPD_MX] = &mx,
> [RPMHPD_MX_AO] = &mx_ao,
> [RPMHPD_MXC] = &mxc,
> [RPMHPD_MXC_AO] = &mxc_ao,
> - [RPMHPD_MSS] = &mss,
> [RPMHPD_NSP] = &nsp,
> [RPMHPD_NSP2] = &nsp2,
> - [RPMHPD_GMXC] = &gmxc,
> };
>
> static const struct rpmhpd_desc glymur_desc = {
> @@ -834,15 +834,15 @@ static struct rpmhpd *x1e80100_rpmhpds[] = {
> [RPMHPD_CX_AO] = &cx_ao,
> [RPMHPD_EBI] = &ebi,
> [RPMHPD_GFX] = &gfx,
> + [RPMHPD_GMXC] = &gmxc,
> [RPMHPD_LCX] = &lcx,
> [RPMHPD_LMX] = &lmx,
> [RPMHPD_MMCX] = &mmcx,
> [RPMHPD_MMCX_AO] = &mmcx_ao,
> [RPMHPD_MX] = &mx,
> [RPMHPD_MX_AO] = &mx_ao,
> - [RPMHPD_NSP] = &nsp,
> [RPMHPD_MXC] = &mxc,
> - [RPMHPD_GMXC] = &gmxc,
> + [RPMHPD_NSP] = &nsp,
> };
>
> static const struct rpmhpd_desc x1e80100_desc = {
> @@ -860,10 +860,10 @@ static struct rpmhpd *qcs8300_rpmhpds[] = {
> [RPMHPD_LMX] = &lmx,
> [RPMHPD_MMCX] = &mmcx_w_cx_parent,
> [RPMHPD_MMCX_AO] = &mmcx_ao_w_cx_parent,
> - [RPMHPD_MXC] = &mxc,
> - [RPMHPD_MXC_AO] = &mxc_ao,
> [RPMHPD_MX] = &mx,
> [RPMHPD_MX_AO] = &mx_ao,
> + [RPMHPD_MXC] = &mxc,
> + [RPMHPD_MXC_AO] = &mxc_ao,
> [RPMHPD_NSP0] = &nsp0,
> [RPMHPD_NSP1] = &nsp1,
> };
> --
> 2.53.0
>