Re: [PATCH v5 5/5] PCI: qcom: Add D3cold support

[Steev Klimaszewski]

Hi Mani,

On Wed, Jul 8, 2026 at 2:53 AM Manivannan Sadhasivam <mani@xxxxxxxxxx> wrote:
>
> On Mon, Jun 29, 2026 at 04:16:14PM -0500, Steev Klimaszewski wrote:
> > Hi Krishna, and Mani,
> >
> > Turns out, this patchset causes issues but only on some machines.  On a WDK2023
> > (Volterra), this breaks suspend, and on *my* X13s, it also seems to when using
> > the command `sudo rtcwake -m freeze -s 300` when resuming it crashes the
> > machine.  Interestingly, it does not crash on another user's X13s.
> >
> > Included is the info from Volterra's lspci -vvv and further down will be my
> > lspci -vvv - my X13s has a WD_BLACK 2TB SN770M in it which is not what it came
> > with from Lenovo.
> >
>
> I tested suspend/resume on my x13s and it did not crash. So the difference seems
> to be with the SSDs. I did compare my lspci output and yours, but couldn't spot
> anything obvious.
>
> Since NVMe devices do not support wakeup, the pcie-qcom driver should be
> transitioning the devices into D3Cold. But I'm not sure why the crash happens
> only with these SSDs.
>
> Since both devices have ASPM enabled, can you quickly try booting with
> 'pcie_aspm=off' in cmdline and suspend?
>
> - Mani

With pcie_aspm=off it still crashes on my X13s when resuming from suspend