Re: [PATCH 2/9] ax88179_178a: Add HW support for AX179A-based chips

[Birger Koblitz]

On 7/1/26 17:05, Andrew Lunn wrote:
> >   #include <linux/usb/usbnet.h>
> >   #include <uapi/linux/mdio.h>
> >   #include <linux/mdio.h>
> > +#include <linux/if_vlan.h>
>
> Does this patch require this header?
Yes, because of the use of __vlan_hwaccel_put_tag later in the patch.

> > @@ -414,7 +570,6 @@ static int ax88179_suspend(struct usb_interface *intf, pm_message_t message)
> >   
> >   	usbnet_suspend(intf, message);
> >   
> > -	/* Enable WoL */
> >   	if (priv->wolopts) {
>
> Please try to avoid changes like this.
Fixed in v2.

> >   	/* Force bulk-in zero length */
> >   	ax88179_read_cmd(dev, AX_ACCESS_MAC, AX_PHYPWR_RSTCTL,
> > -			 2, 2, &tmp16);
> > +			2, 2, &tmp16);
> >   
> >   	tmp16 |= AX_PHYPWR_RSTCTL_BZ | AX_PHYPWR_RSTCTL_IPRL;
> >   	ax88179_write_cmd(dev, AX_ACCESS_MAC, AX_PHYPWR_RSTCTL,
> > -			  2, 2, &tmp16);
> > +			2, 2, &tmp16);
>
> Please put white space changes in another patch.
Will be removed from v2.

> > +	/* Initialize MII structure */
> > +	dev->mii.dev = dev->net;
> > +	dev->mii.mdio_read = ax88179_mdio_read;
> > +	dev->mii.mdio_write = ax88179_mdio_write;
> > +	dev->mii.phy_id_mask = 0xff;
> > +	dev->mii.reg_num_mask = 0xff;
> > +	dev->mii.phy_id = 0x03;
>
> If this device is going to have a long term future, it really should
> move to phylink.

As discussed previously, I started converting the code to phylink,
but for the PHYs implemented as IP-cores in the the AX88179A-based chips,
the behaviour of the PHYs is so different from their discrete counterparts
because of other firmware used, that even if they have the same PHY-ID as
their discrete counterparts, they behave entirely differently and in a
way that is adapted to being used via USB as part of a USB-Ethernet
adapter.

Only few of the USB-Ethernet drivers presently use phylink (asix,
lan78xx), btw.

Birger