Re: [PATCH v2] usb: typec: tcpm: implement retry mechanism for Discover Identity VDMs

[RD Babiera]

On Tue, Jun 30, 2026 at 2:45 AM Xu Yang <xu.yang_2@xxxxxxxxxxx> wrote:

Thanks for the feedback Xu, and apologies for the small delay here.

> Can we utilize FOREACH_VDM_DISCOVERY() just like tcpm_state does?
> Then you don't need to write them again.

Makes sense, will add to next version.

> >
> > +
>
> You add a blank line here.

Thanks for the catch here.

> I see a loop: SRC_VDM_IDENTITY_REQUEST -> SRC_SEND_CAPABILITIES -> SRC_VDM_IDENTITY_REQUEST.
> The tcpm should go to SRC_VDM_IDENTITY_REQUEST state only once here, right?

Interweaving SRC_VDM_IDENTITY_REQUEST between retries of
SRC_SEND_CAPABILITIES was intentional
when SRC_VDM_IDENTITY_REQUEST was implemented for SOP' in order to
pass USBDP Compliance Test
timing requirements. This is consistent with the current
implementation, do correct me if you're experiencing
otherwise though.

Best,
RD