Re: [PATCH v4 4/7] serial: 8250_aspeed_vuart: add VUART over PCI

[Jiri Slaby]

On 08. 07. 26, 18:46, Andrew Lunn wrote:
> > +	if (silicon_revision_id == AST2600A3_REVISION_ID)
> > +		rc = regmap_update_bits(scu, ASPEED_SCUC24,
> > +					ASPEED_SCUC24_PCIDEV1_INTX_MSI_HOST2BMC_EN | ASPEED_SCUC24_MSI_ROUTING_MASK,
> > +					ASPEED_SCUC24_PCIDEV1_INTX_MSI_HOST2BMC_EN | ASPEED_SCUC24_MSI_ROUTING_PCIE2LPC_PCIDEV1);
> > +	else
> > +		rc = regmap_update_bits(scu, ASPEED_SCUC24,
> > +					/**
> > +					 * The bit 14 is reserved in the Datasheet.
> > +					 */
> > +					ASPEED_SCUC24_PCIDEV1_INTX_MSI_SCU560_EN | BIT(14) | ASPEED_SCUC24_MSI_ROUTING_MASK,
> > +					ASPEED_SCUC24_PCIDEV1_INTX_MSI_SCU560_EN | BIT(14) | ASPEED_SCUC24_MSI_ROUTING_PCIE2LPC_PCIDEV1);
>
> checkpatch should be warning about these long lines. Traditionally,
> the limit is 80 character lines, but recently 100 has been accepted by
> some subsystems. The exception is when wrapping the lines will make
> them less readable, but i don't think that applies here.

FWIW 100 is fine by me. 80 is too ancient limit.

--
js
suse labs