Re: [PATCH] i2c: designware: amdisp: balance genpd on probe failure

[Bin Du]

On 7/9/2026 2:04 PM, Mukesh Savaliya wrote:
> Looks fine to me, Have someone from AMD also Ack'ing this as requested
> by Andy Shevchenko.
> 
> On 7/8/2026 2:35 PM, Guangshuo Li wrote:
>> The change referenced by the Fixes tag avoids a runtime PM resume during
>> probe by powering the ISP domain directly with dev_pm_genpd_resume()
>> before calling i2c_dw_probe(). Runtime PM is enabled only after
>> i2c_dw_probe() has succeeded.
>>
>> However, the i2c_dw_probe() failure path still uses the old runtime PM
>> cleanup path. At that point pm_runtime_enable() has not been called yet,
>> so pm_runtime_disable() is not paired with any enable. The failure path
>> also skips the dev_pm_genpd_suspend() needed to balance the direct
>> dev_pm_genpd_resume() call.
>>
>> Suspend the genpd on the i2c_dw_probe() failure path instead of disabling
>> runtime PM. This keeps the direct genpd resume/suspend pairing symmetric
>> on both success and failure paths.
>>
>> Fixes: e2f1ada8e089 ("i2c: designware: amdisp: Fix resume-probe race
>> condition issue")
>> Signed-off-by: Guangshuo Li <lgs201920130244@xxxxxxxxx>
>> ---
>>   drivers/i2c/busses/i2c-designware-amdisp.c | 6 +++---
>>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> Acked-by: Mukesh Kumar Savaliya <mukesh.savaliya@xxxxxxxxxxxxxxxx>
> 

Acked-by: Bin Du <bin.du@xxxxxxx>
Tested-by: Bin Du <bin.du@xxxxxxx>