Re: [PATCH v3 12/15] serial: 8250: allow low-level drivers to override break control

[Jiri Slaby]

On 09. 07. 26, 7:33, Crescent Hsieh wrote:
> --- a/drivers/tty/serial/8250/8250_port.c
> +++ b/drivers/tty/serial/8250/8250_port.c
> @@ -1937,7 +1937,7 @@ static void serial8250_set_mctrl(struct uart_port *port, unsigned int mctrl)
>   		serial8250_do_set_mctrl(port, mctrl);
>   }
>   
> -static void serial8250_break_ctl(struct uart_port *port, int break_state)
> +void serial8250_do_break_ctl(struct uart_port *port, int break_state)
>   {
>   	struct uart_8250_port *up = up_to_u8250p(port);
>   
> @@ -1950,6 +1950,15 @@ static void serial8250_break_ctl(struct uart_port *port, int break_state)
>   		up->lcr &= ~UART_LCR_SBC;
>   	serial_port_out(port, UART_LCR, up->lcr);
>   }
> +EXPORT_SYMBOL_NS_GPL(serial8250_do_break_ctl, "SERIAL_8250_PCI");

I doubt this is the right NS.

thanks,
--
js
suse labs