Re: [PATCH 3/6] MIPS: vdso: Stop using CONFIG_HAVE_GENERIC_VDSO

[Vincenzo Frascino]

On 09/07/2026 08:28, Thomas Weißschuh wrote:
> HAVE_GENERIC_VDSO is about to become an implementation detail.
> 
> Use the MIPS-specific symbol instead. It is equivalent here.
> 
> Signed-off-by: Thomas Weißschuh <thomas.weissschuh@xxxxxxxxxxxxx>

Reviewed-by: Vincenzo Frascino <vincenzo.frascino@xxxxxxx>

> ---
>  arch/mips/kernel/vdso.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/mips/kernel/vdso.c b/arch/mips/kernel/vdso.c
> index bd1fc17d3975..29a10045f2b6 100644
> --- a/arch/mips/kernel/vdso.c
> +++ b/arch/mips/kernel/vdso.c
> @@ -129,7 +129,7 @@ int arch_setup_additional_pages(struct linux_binprm *bprm, int uses_interp)
>  	 * This ensures that when the kernel updates the VDSO data userland
>  	 * will observe it without requiring cache invalidations.
>  	 */
> -	if (cpu_has_dc_aliases && IS_ENABLED(CONFIG_HAVE_GENERIC_VDSO)) {
> +	if (cpu_has_dc_aliases && IS_ENABLED(CONFIG_MIPS_GENERIC_GETTIMEOFDAY)) {
>  		base = __ALIGN_MASK(base, shm_align_mask);
>  		base += ((unsigned long)vdso_k_time_data - gic_size) & shm_align_mask;
>  	}
> @@ -137,7 +137,7 @@ int arch_setup_additional_pages(struct linux_binprm *bprm, int uses_interp)
>  	data_addr = base + gic_size;
>  	vdso_addr = data_addr + VDSO_NR_PAGES * PAGE_SIZE;
>  
> -	if (IS_ENABLED(CONFIG_HAVE_GENERIC_VDSO)) {
> +	if (IS_ENABLED(CONFIG_MIPS_GENERIC_GETTIMEOFDAY)) {
>  		vma = vdso_install_vvar_mapping(mm, data_addr);
>  		if (IS_ERR(vma)) {
>  			ret = PTR_ERR(vma);
> 

-- 
Regards,
Vincenzo