Re: [PATCH 4/6] vDSO: Automatically select HAVE_GENERIC_VDSO if necessary

[Vincenzo Frascino]

On 09/07/2026 08:28, Thomas Weißschuh wrote:
> gettimeofday() and getrandom() in the vDSO require the vDSO datastore.
> 
> Enable it automatically if either one of them is enabled so the
> architecture code doesn't need to know this.
> 
> Signed-off-by: Thomas Weißschuh <thomas.weissschuh@xxxxxxxxxxxxx>

Reviewed-by: Vincenzo Frascino <vincenzo.frascino@xxxxxxx>

> ---
>  lib/vdso/Kconfig | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/lib/vdso/Kconfig b/lib/vdso/Kconfig
> index db87ba34ef19..eedb04974fd5 100644
> --- a/lib/vdso/Kconfig
> +++ b/lib/vdso/Kconfig
> @@ -3,10 +3,9 @@
>  config HAVE_GENERIC_VDSO
>  	bool
>  
> -if HAVE_GENERIC_VDSO
> -
>  config GENERIC_GETTIMEOFDAY
>  	bool
> +	select HAVE_GENERIC_VDSO
>  	help
>  	  This is a generic implementation of gettimeofday vdso.
>  	  Each architecture that enables this feature has to
> @@ -21,7 +20,6 @@ config GENERIC_VDSO_OVERFLOW_PROTECT
>  
>  config VDSO_GETRANDOM
>  	bool
> +	select HAVE_GENERIC_VDSO
>  	help
>  	  Selected by architectures that support vDSO getrandom().
> -
> -endif
> 

-- 
Regards,
Vincenzo