Re: [PATCH] s390/uapi: Remove obsolete unistd_32.h from Kbuild file

[Vasily Gorbik]

On Thu, Jul 09, 2026 at 08:59:23AM +0200, Alexander Gordeev wrote:
> On Thu, Jul 09, 2026 at 07:57:15AM +0200, Heiko Carstens wrote:
> > > On repeated builds it results in:
> > > 
> > >   SYSHDR  arch/s390/include/generated/uapi/asm/unistd_32.h
> > >   REMOVE  arch/s390/include/generated/uapi/asm/unistd_32.h
> > 
> > How did you achieve that unistd_32.h is actually generated? The required
> > syscall table information to generate such a header file is not present.
> > This looks very odd to me.
> > 
> > The above should be impossible with current upstream code, and I cannot
> > reproduce it. Any chance you applied Thomas' patch on top of an old commit
> > which still includes compat support?
> 
> I can not reproduce it anymore of course, but I am pretty sure I was
> trying exactly that :/
> 
> > > A complete removal would require changes to arch/s390/kernel/syscalls/Makefile
> > > at least,
> > 
> > I don't think so.
> > 
> > > but we still  might want to have unistd_32.h around.
> > 
> > No, that doesn't make sense. compat support is completely gone, including all
> > header files. The patch looks fine as it is for me, but we need to sort out
> > what you reported.
> 
> Yes, my report is false. Sorry for the noise.

Maybe you have not started with a clean tree.
Anyhow, I'm picking up this patch then.