Re: [PATCH] ALSA: oss: Drop redundant nonseekable_open() return check

[Dan Carpenter]

On Thu, Jul 09, 2026 at 01:00:55PM +0300, Dan Carpenter wrote:
> On Thu, Jul 02, 2026 at 12:02:36PM +0700, phucduc.bui@xxxxxxxxx wrote:
> > From: bui duc phuc <phucduc.bui@xxxxxxxxx>
> > 
> > nonseekable_open() always returns 0, so the error check is unnecessary.
> > Remove the dead error handling path.
> 
> The idea is that it might return errors in the future.
> 

Actually the comments on nonseekable_open() say there is no need to
check.  That would have been useful information to add in the commit
message...

> Also the patch is kind of sloppy...

The sloppiness was fixed in v2.  It's weird that there were no review
comments on lore for this patch.  Are people sending private reviews
now?

regards,
dan carpenter