Re: [PATCH v10 0/7] I2C Mux per channel bus speed

[Andy Shevchenko]

On Thu, Jul 09, 2026 at 10:33:46AM +0200, Marcus Folkesson wrote:
> On Wed, Jul 08, 2026 at 10:37:14PM +0300, Andy Shevchenko wrote:
> > On Wed, Jul 08, 2026 at 02:16:12PM +0200, Marcus Folkesson wrote:

...

> > > - Move {__,}i2c_adapter_set_clk_freq() to i2c-mux.c
> > 
> > Can you point to the discussion where it was suggested, please?
> > It was like ages ago (too many patches to review) and I probably
> > missed and/or forgot the rationale for that. Also if we move
> > to i2c-mux, why do we leave it in the adapter namespace?
> 
> Hrm, it seems like the mailing list wasn't CC:ed for that comment.

Please, be sure next time everything like this important will be available
to all.

> It was suggested by Peter and the rationale to remove it was:
> 
> "
> I'not sure it's a good idea to expose {__,}i2c_adapter_set_clk_freq().
> 
> Do we really want to make it so simple for random (non-mux) I2C drivers
> to muck about with the bus speed? Any bus speed changes not coordinated
> with mux-locked bus speed changes are going to be problematic. This is
> shown by the discussion about D2 for the multi-level mux-locked example
> (patch 5/5) -> it is problematic even when the bus speed is changed by
> the mux code itself.
> 
> I think these helpers should be moved from i2c.h to i2c-mux.c.
> "

Okay, let's assume I'm fine with this reasoning, I would still go with
the proper namespace. Otherwise it's inconsistent.

-- 
With Best Regards,
Andy Shevchenko