Re: [PATCH] gpio: mvebu: use devm_clk_get_optional_enabled()

[Andrew Lunn]

> So is the clock optional or is it not? The answer determines the correct
> clk API to use.

The Orion5x family does not have the clock. As far as i remember, all
the other families using this driver do have the clock. And for this
line of Marvell devices, if the clock exists, you need it ticking,
otherwise the hardware just wedges if you access registers with the
clock disabled.

Also, as far as i remember, the Orion5x family does not have the PWM
extension to the GPIO controller. I don't remember the code well
enough, but it is possible the missing clock check is dual purpose, it
also detects an invalid DT when Orion5x has PWM properties when it
should not?

       Andrew