Re: [PATCH v3] platform/x86: ishtp_eclite: Fix ACPI device reference leak in probe error path

From: Ilpo Järvinen

Date: Thu Jul 09 2026 - 09:52:21 EST


On Wed, 24 Jun 2026 09:49:09 +0800, Ma Ke wrote:

> ecl_ishtp_cl_probe() acquires a reference to an ACPI device via
> acpi_find_eclite_device() but fails to release it in the error path
> when acpi_opregion_init() fails. This results in a reference count
> leak, preventing proper cleanup of the ACPI device.
>
> Calling path: acpi_find_eclite_device() ->
> acpi_dev_get_first_match_dev() -> acpi_dev_get_next_match_dev() ->
> bus_find_device() -> get_device().
>
> [...]

Thank you for your contribution, it has been applied to my local
review-ilpo-next branch. Note it will show up in the public
platform-drivers-x86/review-ilpo-next branch only once I've pushed my
local branch there, which might take a while.

FYI [if applicable to your patch], as per Linus' policy change, also
fixes are mostly routed through for-next unless the fix is for a
commit introduced in the most recent cycle or is clearly a regression
fix.

The list of commits applied:
[1/1] platform/x86: ishtp_eclite: Fix ACPI device reference leak in probe error path
commit: e65e4242cd8babee019e575d85dd21261a68e4e2

--
i.