Re: [PATCH net-next 2/4] net: usb: centralize usbnet_cdc_zte_rx_fixup in usbnet

[Paolo Abeni]

On 7/6/26 2:00 PM, Oliver Neukum wrote:
> On 02.07.26 20:19, Manuel Ebner wrote:
>> On Thu, 2026-07-02 at 16:25 +0200, Oliver Neukum wrote:
> 
>>>
>>> diff --git a/drivers/net/usb/usbnet.c b/drivers/net/usb/usbnet.c
>>> index 5544af1f4aa5..7beea6d0e731 100644
>>> --- a/drivers/net/usb/usbnet.c
>>> +++ b/drivers/net/usb/usbnet.c
>>> @@ -2347,6 +2347,25 @@ void usbnet_cdc_status(struct usbnet *dev, struct urb *urb)
>>>   	}
>>>   }
>>>   EXPORT_SYMBOL_GPL(usbnet_cdc_status);
>>> +
>>> +/* Make sure packets have correct destination MAC address
>>     /*
>>      * Make sure packets have the correct destination MAC address
> 
> This sort of puts me into a conundrum. Does networking code use
> the short style of comments or not? The documentation says that it does.
> I am fine either way, but I need a clear rule.
Networking code used to require

/* for
 * multiline comments
 */

but somewhat recently we switched to accept also the more common

/*
 * multiline comment
 */

Checkpatch accepts both; it's not a deal breaker either ways.

/P