Re: [PATCH v4 1/7] dt-bindings: serial: 8250: aspeed: add compatible string for ast2600
From: Grégoire Layet
Date: Thu Jul 09 2026 - 10:31:34 EST
Hi Krzysztof,
On Thu, 9 Jul 2026 at 10:50, Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote:
>
> On Wed, Jul 08, 2026 at 03:35:53PM +0000, Grégoire Layet wrote:
> > The ast2600 was using the ast2500 vuart compatible string.
> > Make it possible to have ast2600-specific properties.
>
> Then add these properties here as well. Adding a new device is one
> commit: its compatible and its properties.
I thought it was necessary to split the two. I will squash the two
dt-bindings commits for the next revision.
> > aspeed,sirq-polarity-sense:
> > $ref: /schemas/types.yaml#/definitions/phandle-array
> > description: |
> > - Phandle to aspeed,ast2500-scu compatible syscon alongside register
> > - offset and bit number to identify how the SIRQ polarity should be
> > - configured. One possible data source is the LPC/eSPI mode bit. Only
> > - applicable to aspeed,ast2500-vuart.
> > + Phandle to aspeed,ast2500-scu or aspeed,ast2600-scu compatible syscon
>
> This is a deprecated property, so it cannot apply to a new device -
> aspeed,ast2600-vuart. You cannot use deprecated code for new bindings or
> device support.
True, I'll remove it.
Regards,
Grégoire