Re: [PATCH v3 2/2] spi: qcom-geni: Fix missing error check on pm_runtime_get_sync()

[Mark Brown]

On Mon, Jul 06, 2026 at 02:23:10PM +0530, Praveen Talari wrote:
> spi_geni_init() calls pm_runtime_get_sync() to power up the device
> before accessing hardware registers, but never checks the return value.

> @@ -693,10 +698,7 @@ static int spi_geni_init(struct spi_geni_master *mas)
>  		writel(spi_tx_cfg, se->base + SE_SPI_TRANS_CFG);
>  	}
>  
> -out_pm:
> -	pm_runtime_put(mas->dev);
>  	return ret;
> -}
>  
>  static unsigned int geni_byte_per_fifo_word(struct spi_geni_master *mas)

The above breaks the build due to removing the closing brace for the
function:

/build/stage/linux/drivers/spi/spi-geni-qcom.c: In function ‘spi_geni_init’:
/build/stage/linux/drivers/spi/spi-geni-qcom.c:712:21: error: invalid storage class for function ‘geni_byte_per_fifo_word’
  712 | static unsigned int geni_byte_per_fifo_word(struct spi_geni_master *mas)
      |                     ^~~~~~~~~~~~~~~~~~~~~~~
/build/stage/linux/drivers/spi/spi-geni-qcom.c:726:13: error: invalid storage class for function ‘geni_spi_handle_tx’
  726 | static bool geni_spi_handle_tx(struct spi_geni_master *mas)
      |             ^~~~~~~~~~~~~~~~~~
/build/stage/linux/drivers/spi/spi-geni-qcom.c:764:13: error: invalid storage class for function ‘geni_spi_handle_rx’
  764 | static void geni_spi_handle_rx(struct spi_geni_master *mas)
      |             ^~~~~~~~~~~~~~~~~~
/build/stage/linux/drivers/spi/spi-geni-qcom.c:808:12: error: invalid storage class for function ‘setup_se_xfer’
  808 | static int setup_se_xfer(struct spi_transfer *xfer,

and so on.

Attachment: signature.asc
Description: PGP signature