Re: [PATCH v6 07/11] KVM: TDX: Allocate PAMT memory for TD and vCPU control structures

[Yan Zhao]

On Fri, Jul 10, 2026 at 09:04:57AM +0800, Edgecombe, Rick P wrote:
> On Thu, 2026-07-09 at 11:18 +0800, Yan Zhao wrote:
> > > > > page before gifting it to the TDX module, and tear it down after the
> > > > > page is reclaimed.
> > > > How about
> > > > "So the kernel must check whether it is necessary to install/remove PAMT
> > > > backing for each 4KB page, and do so when necessary before gifting the
> > > > page to the TDX module or after it is reclaimed." ?
> > > 
> > > The checking part is true, but is it needed to understand this patch? I
> > > think it just needs a background of what is happening. How about:
> > > 
> > > So the kernel must install PAMT backing for any 4KB page being gifting to
> > > the TDX module, and tear down the backing when the associated gifted pages
> > > are reclaimed.
> > Hmm. I'm not sure if it would be confusing for people without sufficient
> > background, because the kernel only needs to install PAMT backing before the
> > gifting the first 4KB page.
> > 
> > How about:
> > So the kernel must ensure PAMT backing installed for any 4KB page being
> > gifting to the TDX module, and tear down the backing when all associated
> > gifted pages are reclaimed.
> I see how it's better. I added a few missed word tweaks and ended up with:
> 
> So the kernel must ensure PAMT backing is installed for any 4KB page being
> gifting to the TDX module, and must tear down the backing when all associated
> gifted pages are reclaimed.
It's better! Thanks!