Re: [PATCH v1 2/4] platform/x86: bitland-mifs-wmi: Merge the function of redmi-wmi into the bitland driver

[Mingyou Chen]

On 7/10/26 12:07 AM, Nika Krasnova wrote:
> WMI_EVENT_FN_4 is missing from this ignore block (the old keymap had
> it). FN_4 events on Bitland will now fall through to the "Unknown WMI
> hotkey" path instead of being ignored. Looks like an accidental drop in
> the reformat.

My device never report the FN_* events

But them exist in the C# userspace driver. (Might for other bitland devices)

> This remap runs on every machine, not just Redmi. If the firmware emits
> a CPU fan-speed event of 0 (e.g. the fan spinning down), it gets misread
> as KEY_REFRESH_RATE_TOGGLE. Could it be gated on DMI rather than on
> value == 0?

My device never report the fan speed events.

In the current driver, the hwmon status is implemented in a pull model 
(laptop_hwmon_read) by wmi calls

So I think the unnecessary events could be removed.

--

Mingyou Chen