Re: [PATCH v1 1/2] dt-bindings: sound: add Texas Instruments TAS2557

[Wang, Sen]

On 7/9/2026 5:13 PM, Gianluca Boiano wrote:
> Document the TAS2557 mono Class-D smart amplifier with an integrated
> DSP for speaker protection. The device is controlled over I2C and
> receives audio over I2S/TDM (ASI). It can drive a single mono speaker
> or, as two devices, a stereo pair; in that case the ti,channel
> property selects the audio slot each device reproduces and the
> per-device tuning it applies.
>
> The on-chip DSP boots from a firmware image generated per speaker
> design with the TI PurePath Console tuning tools; the optional
> firmware-name property selects a board-specific image.
>
> Signed-off-by: Gianluca Boiano <morf3089@xxxxxxxxx>

Hi Gianluca, thanks for the patch.

> ---
>   .../devicetree/bindings/sound/ti,tas2557.yaml | 123 ++++++++++++++++++
>   MAINTAINERS                                   |   1 +
>   2 files changed, 124 insertions(+)
>   create mode 100644 Documentation/devicetree/bindings/sound/ti,tas2557.yaml
>
> diff --git a/Documentation/devicetree/bindings/sound/ti,tas2557.yaml b/Documentation/devicetree/bindings/sound/ti,tas2557.yaml
> new file mode 100644
> index 000000000000..b1d1183c4a79
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/ti,tas2557.yaml
> @@ -0,0 +1,123 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +# Copyright (C) 2026 Gianluca Boiano <morf3089@xxxxxxxxx>
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/sound/ti,tas2557.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Texas Instruments TAS2557 Mono Smart Amplifier
> +
> +maintainers:
> +  - Gianluca Boiano <morf3089@xxxxxxxxx>
> +
> +description: |
> +  The TAS2557 is a mono, digital-input Class-D amplifier with an
> +  integrated DSP for speaker protection. Audio is carried over I2S/TDM
> +  (ASI). The on-chip DSP boots from a firmware image that is generated
> +  for a specific speaker design using the TI PurePath Console tuning
> +  tools.
> +
> +  Stereo playback is built from two devices, each reproducing one audio
> +  slot selected through the ti,channel property and applying the
> +  matching per-device tuning contained in a stereo-tuned firmware
> +  image.
> +
> +  Datasheet: https://www.ti.com/lit/gpn/tas2557
> +
> +allOf:
> +  - $ref: dai-common.yaml#
> +
> +properties:
> +  compatible:
> +    const: ti,tas2557
> +
> +  reg:
> +    maxItems: 1
> +
> +  '#sound-dai-cells':
> +    const: 0
> +
> +  reset-gpios:
> +    maxItems: 1
> +    description: GPIO connected to the active-low RESET pin.
> +
> +  interrupts:
> +    maxItems: 1
> +    description: Fault interrupt output (INT).
> +
> +  vbat-supply:
> +    description: Battery/boost input supply (VBAT), 2.9 V to 5.5 V.
> +
> +  iovdd-supply:
> +    description: Digital I/O supply, 1.62 V to 3.6 V.
> +
> +  avdd-supply:
> +    description: Analog supply, 1.65 V to 1.95 V.
> +
> +  dvdd-supply:
> +    description: Digital core supply, 1.65 V to 1.95 V.
> +
> +  ti,imon-slot-no:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    description: TDM TX time slot for current-sense data.
> +    default: 0
> +    minimum: 0
> +    maximum: 7
> +
> +  ti,vmon-slot-no:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    description: TDM TX time slot for voltage-sense data.
> +    default: 2
> +    minimum: 0
> +    maximum: 7
> +
> +  ti,channel:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    description: |
> +      Audio slot of the stereo stream reproduced by this device (0 =
> +      left, 1 = right). With stereo firmware this also selects which
> +      per-device tuning set is applied.
> +    enum: [0, 1]
> +    default: 0
> +
> +  firmware-name:
> +    $ref: /schemas/types.yaml#/definitions/string
> +    description: |
> +      Name of the DSP firmware image to load. Defaults to a name
> +      derived from the silicon revision. Stereo systems typically use
> +      a stereo-tuned image shared by both devices.
> +
> +required:
> +  - compatible
> +  - reg
> +  - '#sound-dai-cells'

+	ret = devm_regulator_bulk_get_enable(dev, 	ARRAY_SIZE(tas2557_supplies),
+					     tas2557_supplies);
+	if (ret)
+		return dev_err_probe(dev, ret,
+				     "failed to get/enable supplies\n");

Looks like all supplies listed above is mandatory in the driver, please 
make sure you list them here in the required as well.

Best,
Sen Wang