Re: [PATCH] wifi: mwifiex: bound uAP association event IEs to the event buffer
From: Francesco Dolcini
Date: Fri Jul 10 2026 - 03:28:30 EST
Hello Brian, Johannes
On Mon, Jun 29, 2026 at 09:03:33PM +0900, HE WEI (ギカク) wrote:
> mwifiex_process_uap_event() handles EVENT_UAP_STA_ASSOC by exposing the
> (re)association request IEs that the firmware copies into the event:
>
> sinfo->assoc_req_ies = &event->data[len];
> len = (u8 *)sinfo->assoc_req_ies - (u8 *)&event->frame_control;
> sinfo->assoc_req_ies_len = le16_to_cpu(event->len) - (u16)len;
>
> event->len is supplied by the device firmware and is never validated,
I think we received a few patches that are validating the data received
from the firmware (including this one).
I did not review any of them yet, what is your opinion on those?
Should we consider the firmware trust-worth or should we validate
everything we receive from it? Is there some agreement on this topic in
general?
Francesco