Re: [PATCH v3 04/12] livepatch/klp-build: build LoongArch with -fPIC to keep GOT-indirect symbol references
From: George Guo
Date: Fri Jul 10 2026 - 03:39:07 EST
Hi Joe,
> This might be my personal preference, but I think it would be quicker to
> review patches: [...] if they were squashed into one patch.
[...]
> the combined commit remains complete thought, i.e. for LoongArch
> KLP builds, replace the arch's KBUILD_CFLAGS_KERNEL (dropping -fPIE and
> -mdirect-extern-access) and add -fPIC via KCFLAGS instead.
Makes sense. I'll squash patches 03 and 04 into a single patch and drop
the forward/backward references from the commit message.
> I'd also pull out the configuration checks into validate_config() to be
> consistent:
[...]
> and then build_kernel() only needs to adjust the cmd / flags accordingly.
Agreed. I'll move the CONFIG_RELOCATABLE / CONFIG_AS_HAS_EXPLICIT_RELOCS
checks into validate_config() and leave build_kernel() to just set the
flags.
Thanks,
George