Re: [PATCH net-next 01/10] net: dsa: microchip: implement ksz8463_setup()

[Bastien Curutchet]

Hi all,

On 7/9/26 8:42 AM, Bastien Curutchet (Schneider Electric) wrote:
> KSZ8463 uses the ksz8_setup() as setup() callback for its DSA
> operations. Its behavior is quite different than other KSZ8 switches,
> especially its interrupt scheme.
>
> Remove from the ksz8_setup()/ksz8_reset_switch() everything that is
> ksz8463-related.
> Create a dedicated ksz8463_setup() and a ksz8463_reset_switch() function.
> This new ksz8463_setup() is widely inspired from ksz8_setup, it has
> following differences:
> - it doesn't configure drive strength (not supported on KSZ8463)
> - it uses the ksz8463_reset_switch()
> - it doesn't configure IRQs

Sashiko said "Can this cause a probe failure or interrupt corruption 
when a hardware interrupt is configured in the device tree?"

It doesn't cause a probe failure on my setup. However, I think it's 
right when it says that the IRQ setup could lead to 'erroneously return 
an active Linux IRQ belonging to another hardware device'.

I'll change the patch order in next iteration and put this one after the 
KSZ8463 interrupt support to avoid this issue.



FYI, Sashiko made two other comments on this patch about bugs that would 
be triggered when 'the DSA master netdev is rebound'. I'm not sure to 
understand how these bugs can be triggered and the comments start with 
'This isn't a bug introduced by this patch' so I don't plan to 
investigate it further.


Best regards,
Bastien