Re: [PATCH v3 1/2] ASoC: dt-bindings: qcom,wsa8855: add Qualcomm WSA8855 speaker amplifier
From: Krzysztof Kozlowski
Date: Fri Jul 10 2026 - 05:18:30 EST
On Thu, Jul 09, 2026 at 11:29:14PM +0530, Prasad Kumpatla wrote:
> +allOf:
> + - $ref: dai-common.yaml#
> +
> +properties:
> + compatible:
> + const: qcom,wsa8855
> +
> + reg:
> + maxItems: 1
> +
> + '#sound-dai-cells':
> + const: 0
> +
> + powerdown-gpios:
> + description: GPIO controlling the SD_N powerdown pin.
> + maxItems: 1
> +
> + reset-gpios:
> + description: GPIO controlling the SD_N powerdown pin.
I think it is easier to go with reset-gpios only. There is no benefit in
allowing both in DTS. There is also almost no benefit in having driver
support for both. With reset-gpios you support both cases - shared and
single-line GPIO.
Well, in any case (I don't object):
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxxxxx>
Best regards,
Krzysztof