Re: [PATCH 1/2] hwmon: (asus-ec-sensors) add T_Sensor for ROG STRIX X870E-E GAMING WIFI

[Guenter Roeck]

Eugene,

On 7/9/26 22:47, Eugene Shalygin wrote:
> Hi Guenter,
>
> On Fri, 10 Jul 2026 at 06:58, Guenter Roeck <linux@xxxxxxxxxxxx> wrote:
> > > Enable T_Sensor for ROG STRIX X870E-E GAMING WIFI. Board specs list the
> > > sensor, reading return -62, which is one of the blank values for
> > > temperature sensors in the ASUS EC.
> >
> > Just like Sashiko, I don't really understand this patch or, rather,
> > its description. What is the point of adding a sensor which is expected
> > to return -62 ?
>
> The motherboard provides sockets where users can connect thermistors
> (T_Sensor, Water_In, Water_Out). When the socket is empty, readings
> the sensor value returns a special blank value, which is -40 for older
> board generations (maybe BIOSes?) and -62 for the newer ones. It is a
> good flag that the temperature sensor "exists" at the given EC
> registry index. Hope this clarifies the motivations behind the commit.
>
> I should have noted those values and properly return -ENODATA, but now
> I'm not sure which board family uses which value. I will try to
> salvage this information from my notes and the Libre Hardware Monitor
> project (where I implemented blanks from the beginning and users fill
> that bit of information when adding support for their motherboards),
> but for now the driver returns those blank values as is when actual
> sensor is not connected. If that fails I will likely test for both for
> all the boards... Anyhow, this shortcomings will be addressed.

Do you expect me (or anyone else) to be able to deduct that from
the patch description above ?

Guenter