Re: [PATCH v5 0/4] platform/x86: hp-bioscfg: fix ACPI package handling on HP EliteBook 840 G2

[Ilpo Järvinen]

On Thu, 09 Jul 2026 21:58:55 +0500, Muhammad Bilal wrote:

> This series fixes attribute enumeration failures on the HP EliteBook 840
> G2 (BIOS M71 Ver. 01.31), whose BIOS returns shorter ACPI WMI packages
> than hp_init_bios_package_attribute() currently accepts, plus occasional
> type-mismatched elements after a failed WMI query.
> 
> Patches 1 and 2 are prerequisites: they make each per-type parser bound
> itself on the real, validated package count instead of an incorrect value
> derived from the NAME string's length. Both are no-ops today, since
> every package the driver currently handles already meets the old
> minimum size. They matter because patch 3 depends on them: once the
> minimum size check is relaxed, the elements array can genuinely be
> smaller than a parser's fixed per-type count, and without patches 1 and
> 2 this would result in an out-of-bounds heap read.
> 
> [...]

Thank you for your contribution, it has been applied to my local
review-ilpo-next branch. Note it will show up in the public
platform-drivers-x86/review-ilpo-next branch only once I've pushed my
local branch there, which might take a while.

FYI [if applicable to your patch], as per Linus' policy change, also
fixes are mostly routed through for-next unless the fix is for a
commit introduced in the most recent cycle or is clearly a regression
fix.

The list of commits applied:
[1/4] platform/x86: hp-bioscfg: pass validated element count to package parsers
      commit: e0ddfd77c0c320b7d12b6c9169303b140b798775
[2/4] platform/x86: hp-bioscfg: bound ordered-list parsing by the package count
      commit: 1d143d78299d0eb4536698bf98c1815ec69f22a9
[3/4] platform/x86: hp-bioscfg: accept reduced ACPI packages from older HP BIOS
      commit: 40e10e6cc8f70c041431a1e30186807e28ec46e0
[4/4] platform/x86: hp-bioscfg: warn on element type mismatch instead of failing
      commit: b0e2af3ec94e0431adb59d9f249ebbd3b7285158

--
 i.