Re: [PATCH] usb: misc: cypress_cy7c63: check control transfer status

From: Keshav Verma

Date: Fri Jul 10 2026 - 08:10:05 EST


On Fri, Jul 10, 2026 at 3:23 PM Oliver Neukum <oneukum@xxxxxxxx> wrote:

> There is no point in this change. You just allocate yet another
> buffer for no gain.
>
> Regards
> Oliver
>

Hi,

Thanks for the review.

The bug I was trying to address is that read_port() ignores the return
value from vendor_command() and can return stale cached data after a
failed control transfer.

I updated vendor_command() to use usb_control_msg_recv() based on
review feedback on the previous version.

Would you prefer that I keep the existing usb_control_msg()
implementation and resend a v3 containing only the stale data fix?

Thanks,
Keshav Verma