Re: [PATCH 0/2] serial: sc16is7xx: fix TX inter-frame gaps on SPI UARTs

[Greg KH]

On Tue, Jun 23, 2026 at 01:22:23PM +0200, Paul Mbewe wrote:
> This series fixes two related TX path issues in the sc16is7xx SPI UART
> driver that cause visible inter-frame gaps on the wire, breaking Modbus
> RTU communication.
> 
> Patch 1 fixes a data loss / gap caused by kfifo_out_linear_ptr() only
> returning one contiguous segment of the circular buffer. When TX data
> wraps around the kfifo boundary, the remainder is delayed until the next
> TX interrupt, producing a silence gap that violates the Modbus 1.5
> character-time limit.
> 
> Patch 2 raises the TX FIFO trigger level from 8 to 32 free spaces via
> the TLR register. The default trigger of 8 causes excessive SPI
> round-trips on slow single-core hosts, leading to TX FIFO underruns
> between bursts.
> 
> Tested on SC16IS752 (SPI, 1 MHz) on i.MX6ULL driving RS-485 at 115200
> baud. Oscilloscope confirmed both gap types are eliminated after the
> fix.
> 
> Paul Mbewe (2):
>   serial: sc16is7xx: fix TX gap caused by kfifo circular buffer
>     wrap-around
>   serial: sc16is7xx: set TX FIFO trigger level to half FIFO to prevent
>     underruns
> 
>  drivers/tty/serial/sc16is7xx.c | 24 +++++++++++++++++++++---
>  1 file changed, 21 insertions(+), 3 deletions(-)
> 
> -- 
> 2.43.0
> 
> 

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- This looks like a new version of a previously submitted patch, but you
  did not list below the --- line any changes from the previous version.
  Please read the section entitled "The canonical patch format" in the
  kernel file, Documentation/process/submitting-patches.rst for what
  needs to be done here to properly describe this.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot