Re: [PATCH 3/3] ASoC: codecs: wcd9378: add TX/capture codec driver

[Julian Braha]

Hi Jorijn,

On 7/6/26 20:22, Jorijn van der Graaf wrote:
> +config SND_SOC_WCD9378
> +	depends on SND_SOC_WCD9378_SDW
> +	tristate
> +	depends on SOUNDWIRE || !SOUNDWIRE
> +	select SND_SOC_WCD_COMMON

The preferred style for this is 'depends on SOUNDWIRE if SOUNDWIRE'
since 'depends on X if Y' was added recently. Also see the kconfig docs
on "Optional dependencies".

> +config SND_SOC_WCD9378_SDW
> +	tristate "WCD9378 Codec - SDW"
> +	select SND_SOC_WCD9378
> +	depends on SOUNDWIRE
> +	select REGMAP_SOUNDWIRE

Another kconfig style nitpick: could you organize the attributes?
E.g. keep the selects together, and keep the dependencies together?

- Julian Braha