Re: [PATCH v2 6/7] KVM: x86: Move supported EFER bits to kvm_caps

[Nikolay Borisov]

On 7/6/26 22:54, Yosry Ahmed wrote:
> Supported EFER bits naturally fits into kvm_caps because it needs to be
> recomputed during vendor init (e.g. to account for EFER.SVME being
> allowed/disallowed based on nested being enabled/disabled).
>
> Move efer_supported_bits into kvm_caps as supported_efer_bits (for
> naming consistency), and reinitialize it at the beginning of
> kvm_setup_efer_caps(), removing the need to clear unsupported bits in
> vendor code (e.g. EFER.SVME).
>
> As the bitmask is now globally visible as part of kvm_caps, there's
> little use for helpers to enable/disable specific bits, so drop them and
> open-code updates to kvm_caps.supported_efer_bits.
>
> No functional change intended.
>
> Suggested-by: Sean Christopherson <seanjc@xxxxxxxxxx>
> Signed-off-by: Yosry Ahmed <yosry@xxxxxxxxxx>

Reviewed-by: Nikolay Borisov <nik.borisov@xxxxxxxx>

<snip>