Re: [PATCH] ext4: fix use-after-free in ext4 delayed I/O completion
From: Theodore Tso
Date: Fri Jul 10 2026 - 10:06:37 EST
On Thu, Jul 09, 2026 at 02:46:43PM -0500, Matthew Wilcox wrote:
>
> (also if this patch isn't AI slop, it's doing a Really Good Job of
> pretending to be AI slop. Why would you choose 'unsigned short' as
> the type?)
It's AI slop that didn't even bother to run it by an AI patch quality
review process such as Sashiko:
- [High] Skipping `queue_work()` when `igrab()` fails causes a permanent deadlock
during inode eviction by stranding pages in writeback state.
- [High] A data race and logical flaw with the 1-bit `i_rsv_need_iput` flag causes
permanent inode reference leaks during concurrent I/O completions.
Syzbot also reported the inconsistent igrab state issue. So it's AI
slop that wasted resources both with Shashiko and Syzbot....
Longxing Li, whether or not this is AI slop, this patch will tend to
cause me to distrust any future code submissions form you. I suggest
that you test patches and look at the code much more carefully before
sending, if you don't want to have a bad reputation as a patch
submitter.
Best regards,
- Ted