Re: [PATCH v4 2/8] hwmon: sbtsi_temp: Refactor temperature register access into helpers

From: Guenter Roeck

Date: Fri Jul 10 2026 - 10:28:20 EST


On 7/10/26 04:16, Akshay Gupta wrote:
From: Prathima <Prathima.Lk@xxxxxxx>

Extract the paired integer/decimal register reads and writes from the
hwmon read/write callbacks into sbtsi_temp_read() and sbtsi_temp_write()
helpers. This consolidates error handling and respects the ReadOrder bit
for atomic temperature latching.

This keeps register access independent while preserving existing hwmon
functionality.

Reviewed-by: Akshay Gupta <Akshay.Gupta@xxxxxxx>
Signed-off-by: Prathima <Prathima.Lk@xxxxxxx>

Acked-by: Guenter Roeck <linux@xxxxxxxxxxxx>

The overflow problem raised by Sashiko should probably be addressed,
but that does not have to be done with this series.

Thanks,
Guenter