Re: [PATCH] pinctrl: sx150x: add missing MODULE_DEVICE_TABLE()

[Linus Walleij]

On Sat, Jul 4, 2026 at 5:22 PM Pengpeng Hou <pengpeng@xxxxxxxxxxx> wrote:

> The driver has a match table for the i2c bus wired into its driver
> structure, but the table is not exported with MODULE_DEVICE_TABLE().
>
> Add the missing MODULE_DEVICE_TABLE() entry so module alias information
> is generated for automatic module loading.
>
> This is a source-level fix.  It does not claim dynamic hardware
> reproduction; the evidence is the driver-owned match table, its use by
> the driver registration structure, and the missing module alias
> publication.
>
> Signed-off-by: Pengpeng Hou <pengpeng@xxxxxxxxxxx>

Patch applied!

Yours,
Linus Walleij
>  drivers/pinctrl/pinctrl-sx150x.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pinctrl/pinctrl-sx150x.c b/drivers/pinctrl/pinctrl-sx150x.c
> index 1d6760ffe809..f1647d9114e3 100644
> --- a/drivers/pinctrl/pinctrl-sx150x.c
> +++ b/drivers/pinctrl/pinctrl-sx150x.c
> @@ -850,6 +850,7 @@ static const struct i2c_device_id sx150x_id[] = {
>         {"sx1509q", (kernel_ulong_t) &sx1509q_device_data },
>         {}
>  };
> +MODULE_DEVICE_TABLE(i2c, sx150x_id);
>
>  static const struct of_device_id sx150x_of_match[] = {
>         { .compatible = "semtech,sx1501q", .data = &sx1501q_device_data },
> --
> 2.53.0
>