Re: [PATCH v3 2/7] ASoC: apple: mca: Separate data & clock port setup

From: Mark Brown

Date: Fri Jul 10 2026 - 16:41:20 EST


On Sun, Jul 05, 2026 at 01:37:51PM +1000, James Calligeros wrote:
> From: Martin Povišer <povik+lin@xxxxxxxxxxx>
>
> Up until now FEs were always the clock providers -- feeding the clocks
> on any ports (BEs) they are attached to. This will soon change and FEs
> will be allowed to be clock consumers. Once that happens, the routing
> of clocks and data will to some degree decouple.
>
> In advance of the change, make preparations:
>
> * Narrow down semantics of what was formerly the 'port_driver' field
> to refer to clocks only.
>
> * On 'startup' of BEs, separate the clock and data aspects of the port
> setup.

This breaks the build:

/build/stage/linux/sound/soc/apple/mca.c: In function ‘mca_be_hw_free’:
/build/stage/linux/sound/soc/apple/mca.c:363:17: error: ‘struct mca_cluster’ has
no member named ‘port_driver’; did you mean ‘port_clk_driver’?
363 | if (cl->port_driver < 0)
| ^~~~~~~~~~~
| port_clk_driver
/build/stage/linux/sound/soc/apple/mca.c:371:36: error: ‘struct mca_cluster’ has
no member named ‘port_driver’; did you mean ‘port_clk_driver’?
371 | fe_cl = &mca->clusters[cl->port_driver];
| ^~~~~~~~~~~
| port_clk_driver

Attachment: signature.asc
Description: PGP signature