Re: [PATCH v2 33/33] tools/testing/vma: output compared expression on ASSERT_[EQ, NE]()

From: Gregory Price

Date: Fri Jul 10 2026 - 17:10:51 EST


On Fri, Jul 10, 2026 at 09:17:14PM +0100, Lorenzo Stoakes wrote:
> Update the macros to output the compared values at hex for easier debugging
> when test asserts fail.
>
> We have to be careful not to re-evaluate expressions as they may have
> side-effects. So update the code to take local copies and use these for
> both the test and the debug output.

Aw you found it before i reported it :]

>
> Also remove unused IS_SET() macro.
>
> Signed-off-by: Lorenzo Stoakes <ljs@xxxxxxxxxx>


Reviewed-by: Gregory Price <gourry@xxxxxxxxxx>