Re: [PATCH net v2] bnge/bng_re: fix ring ID widths

[Przemek Kitszel]

On 7/10/26 16:25, Vikas Gupta wrote:
> On Fri, Jul 10, 2026 at 3:36 PM Przemek Kitszel
> <przemyslaw.kitszel@xxxxxxxxx> wrote:
> > On 7/4/26 18:47, Vikas Gupta wrote:
> > > Firmware requires more than 16 bits to address TX ring IDs for its
> > > internal QP management. Widen the associated HSI ring ID fields to
> > > 32 bits. The values firmware assigns remain within 24 bits, bounded
> > > by the hardware doorbell XID field.
> > >
> > > RX, completion, and NQ ring IDs are unaffected and remain 16-bit.
> >
> > Here you mention Rx is unaffected. But you touch multiple places that
> > are Rx specific (some comments below).
>
> The fw_ring_id field belongs to bnge_ring_struct, a common struct
> shared by all ring types. Widening it to u32 applies uniformly across
> TX, RX, CP, and NQ rings at the struct level.
> I believe the commit message is incomplete but the intent was that
> firmware assigns values within 16-bit range for all ring types
> except TX, which requires the wider field.
> Please let me know if this clarifies.

Thank you, it does clarify.

Would be nice to extend commit message to include that and also the
info about HW not yet being released. Not sure if it is worth v2 though.

Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@xxxxxxxxx>