Re: [PATCH 2/2] Revert "arm64: Enable vmalloc-huge with ptdump"

From: Lorenzo Stoakes

Date: Sun Jul 12 2026 - 04:27:46 EST


On Sat, Jul 11, 2026 at 01:15:45PM +0300, Mike Rapoport wrote:
> On Fri, Jul 10, 2026 at 11:49:19AM +0100, Lorenzo Stoakes wrote:
> > Subject: [PATCH 2/2] Revert "arm64: Enable vmalloc-huge with ptdump"
>
> Without reading the full changelog this sounds like you are disabling
> vmalloc-huge with ptdump ;-)
>
> How about "remove redundant locking guarding ptdump against vmalloc-huge"?

I'm just following the standard convention when it comes to partial reverts, as
I revert the majority of the patch and I ran 'git revert' to do it ;)

But then again I do remove the arm64 ifdeffery in the same commit and
you're right it does suggest I revert more than I do so will fix it up!

>
> > This partially reverts commit fa93b45fd397 ("arm64: Enable vmalloc-huge
> > with ptdump"), retaining vmalloc-huge support but eliminating the now
> > redundant mitigation against a race between huge vmap page table freeing
> > and ptdump, as this issue has now been fixed at core.
> >
> > We also simultaneously remove the arm64 ifdeffery when acquiring the mmap
> > read lock upon vmap huge page table promotion as it is no longer required.
> >
> > Signed-off-by: Lorenzo Stoakes <ljs@xxxxxxxxxx>B
>
> Acked-by: Mike Rapoport (Microsoft) <rppt@xxxxxxxxxx>

Thanks!

>
> > ---
> > arch/arm64/include/asm/ptdump.h | 2 --
> > arch/arm64/mm/mmu.c | 43 ++++-------------------------------------
> > arch/arm64/mm/ptdump.c | 11 ++---------
> > mm/vmalloc.c | 15 +++-----------
> > 4 files changed, 9 insertions(+), 62 deletions(-)
>
> --
> Sincerely yours,
> Mike.

Thanks, Lorenzo