Re: [PATCH v2 1/2] staging: media: atomisp: clean up block comment formatting in headers

From: Bohdan Derkach

Date: Sun Jul 12 2026 - 09:02:56 EST


Hi Andy,

Thank you for the review and for catching the style issue with the leading /*.

I just checked Ricardo's recent series ("media: atomisp: Remove
doxygen comments") and see that it touches ia_css_timer.h, which
overlaps with my Patch 1.

I will wait for Ricardo's series to be merged into the tree first.
Once it lands, I will rebase my work, fix the /* block comment style,
and send a v3 for any remaining grammar or formatting issues in these
files.

Best regards,
Bohdan Derkach

On Sun, Jul 12, 2026 at 1:34 PM Andy Shevchenko
<andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
>
> On Fri, Jul 10, 2026 at 03:02:53PM +0300, Bohdan D. Marcus wrote:
> > Fix block comment formatting issues in several header files to comply
> > with the Linux kernel coding style. Specifically:
> > - Move trailing '*/' to a separate line.
> > - Align '*' on subsequent lines of block comments.
> > - Reformat excessively long lines and remove Doxygen-style tags.
>
> ...
>
> > /* Purpose of mutex is to protect and serialize use of isp data
> > - * structures and css API calls. */
> > + * structures and css API calls.
> > + */
>
> This still has a problem with the style.
>
> ...
>
> Have you checked patches by Ricardo Ribalda?
>
> ...
>
> Sakari, may you apply Ricardo's first two patches at least, please?
>
> --
> With Best Regards,
> Andy Shevchenko
>
>