Re: [PATCH] net: alacritech: add missing MODULE_DEVICE_TABLE()

[Lino Sanfilippo]

Hi,

On 04.07.26 17:20, Pengpeng Hou wrote:
> The driver has a match table for the pci bus wired into its driver
> structure, but the table is not exported with MODULE_DEVICE_TABLE().
> 
> Add the missing MODULE_DEVICE_TABLE() entry so module alias information
> is generated for automatic module loading.
> 
> This is a source-level fix.  It does not claim dynamic hardware
> reproduction; the evidence is the driver-owned match table, its use by
> the driver registration structure, and the missing module alias
> publication.
> 
> Signed-off-by: Pengpeng Hou <pengpeng@xxxxxxxxxxx>
> ---
>  drivers/net/ethernet/alacritech/slicoss.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/ethernet/alacritech/slicoss.c b/drivers/net/ethernet/alacritech/slicoss.c
> index c1949ca060ca..14b74c09233e 100644
> --- a/drivers/net/ethernet/alacritech/slicoss.c
> +++ b/drivers/net/ethernet/alacritech/slicoss.c
> @@ -34,6 +34,7 @@ static const struct pci_device_id slic_id_tbl[] = {
>  		     PCI_DEVICE_ID_ALACRITECH_OASIS) },
>  	{ 0 }
>  };
> +MODULE_DEVICE_TABLE(pci, slic_id_tbl);
>  
>  static const char slic_stats_strings[][ETH_GSTRING_LEN] = {
>  	"rx_packets",

Reviewed-by: Lino Sanfilippo <LinoSanfilippo@xxxxxx>