Re: [PATCH] driver core: faux: Move a variable assignment behind a condition check in faux_device_destroy()

From: Markus Elfring

Date: Sun Jul 12 2026 - 12:24:37 EST


>> The address of a data structure member was determined before
>> a corresponding null pointer check in the implementation of
>> the function “faux_device_destroy”.
>>
>> Thus avoid the risk for undefined behaviour by moving the assignment
>> for the variable “dev” behind a condition check.
>
> There is no such "undefined behavior" here, sorry, please fix your tools.

Please take another look at related information sources.

EXP34-C: Do not dereference null pointers
https://cmu-sei.github.io/secure-coding-standards/sei-cert-c-coding-standard/rules/expressions-exp/exp34-c/


See also:
https://lore.kernel.org/kernel-janitors/d7a8e34b-e490-47fc-b892-886e1c799c4f@xxxxxx/
https://lkml.org/lkml/2026/7/2/2241

Regards,
Markus