Re: [PATCH] iio: chemical: scd30: remove kernel.h header
From: Joshua Crofts
Date: Sun Jul 12 2026 - 12:52:44 EST
On Sun, 12 Jul 2026 11:42:25 -0500
Maxwell Doose <m32285159@xxxxxxxxx> wrote:
> kernel.h is no longer recommended for usage because it can cause longer
> build times and pull in transient dependencies. In addition, it's not
> being used by the SCD30 driver. Remove it.
>
> Signed-off-by: Maxwell Doose <m32285159@xxxxxxxxx>
> ---
> drivers/iio/chemical/scd30_core.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/iio/chemical/scd30_core.c b/drivers/iio/chemical/scd30_core.c
> index f85cdd8bd84f..40bbf26a667b 100644
> --- a/drivers/iio/chemical/scd30_core.c
> +++ b/drivers/iio/chemical/scd30_core.c
> @@ -23,7 +23,6 @@
> #include <linux/interrupt.h>
> #include <linux/irqreturn.h>
> #include <linux/jiffies.h>
> -#include <linux/kernel.h>
> #include <linux/module.h>
> #include <linux/mutex.h>
> #include <linux/regulator/consumer.h>
Since you're doing IWYU stuff, you should also remove errno.h and
add err.h instead, as the code uses IS_ERR() etc. and err.h includes
errno.h
Also consider grouping the iio headers and asm headers separately.
(separate patch though). The include list looks overwhelming!
--
Kind regards
CJD