Re: [PATCH v4] wifi: brcmfmac: add DPP support

From: Arend van Spriel

Date: Sun Jul 12 2026 - 18:33:29 EST


On Wed, 8 Jul 2026 15:12:30 +0800, Jason Huang wrote:
> Add DPP AKM handling and RSN parsing support. Map DPP to the
> firmware wpa_auth value and recognize DPP public action frames in the
> P2P action-frame TX path.

[...]

> + p2p->bss_idx[P2PAPI_BSSCFG_DEVICE].vif &&
> p2p->bss_idx[P2PAPI_BSSCFG_DEVICE].vif->saved_ie.probe_req_ie_len) {

[...]

> ---
> .../broadcom/brcm80211/brcmfmac/cfg80211.c | 151 ++++++++++--------
> .../broadcom/brcm80211/brcmfmac/p2p.c | 59 +++++--
> .../broadcom/brcm80211/include/brcmu_wifi.h | 2 +

In the v2 review I asked to split the P2P device vif bug fix into a
separate patch with a Fixes: tag for stable backport. The null guard and
the fallback vif in brcmf_p2p_abort_action_frame() are both pre-existing
P2P bugs that should be split out and submitted as a standalone patch so
they can be backported to stable independently of the DPP feature.

Please also add a changelog below the --- line describing what changed
since v3.

Note that the P2P device vif fixes are pre-existing bugs that need to go
to the wireless tree for stable backport, separate from the DPP feature
which targets wireless-next.

Regards,
Arend