Re: [PATCH v3] hwrng: core - Stop/start hwrng_fillfn() kthread before/after suspend-resume

[Herbert Xu]

On Fri, Jul 03, 2026 at 11:20:20AM +0200, Thomas Richard (TI) wrote:
>
> @@ -506,6 +501,29 @@ static struct attribute *rng_dev_attrs[] = {
>  
>  ATTRIBUTE_GROUPS(rng_dev);
>  
> +static void hwrng_start_hwrng_fillfn(void)
> +{
> +	BUG_ON(!mutex_is_locked(&rng_mutex));

BUG_ON is not acceptable.  Please use lockdep_assert_held.

Thanks,
-- 
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt