Re: [PATCH] Signed-off-by: Dylan Liu <dylanliu050903@xxxxxxxxxxxxxx>

From: Dan Carpenter

Date: Mon Jul 13 2026 - 03:47:35 EST


On Sun, Jul 12, 2026 at 10:19:20PM +0800, Dylan Liu wrote:
> staging: iio: adt7316: Fix CamelCase naming for sysfs attributes
>
> Fix multiple checkpatch.pl warnings complaining about CamelCase
> variable and function names.
>
> In order to comply with standard Linux coding style and IIO ABI
> conventions, convert all uppercase abbreviations (AIN, DAC, Vref)
> in the adt7316 driver to lowercase snake_case.
>
> Note that this patch changes the sysfs ABI for this driver, as
> the device attributes exposed to userspace are now lowercase
> (e.g., from 'AIN_internal_Vref' to 'ain_internal_vref'). This is
> necessary to bring the staging driver in line with the official
> IIO ABI.
>
> Signed-off-by: Dylan Liu <dylanliu050903@xxxxxxxxxxxxxx>
> ---
> drivers/staging/iio/addac/adt7316.c | 228 ++++++++++++++--------------
> 1 file changed, 114 insertions(+), 114 deletions(-)
>
> diff --git a/drivers/staging/iio/addac/adt7316.c b/drivers/staging/iio/addac/adt7316.c
> index 59fb3bd26bc1..845d79591128 100644
> --- a/drivers/staging/iio/addac/adt7316.c
> +++ b/drivers/staging/iio/addac/adt7316.c
> @@ -663,7 +663,7 @@ static IIO_DEVICE_ATTR(da_high_resolution, 0644,
> adt7316_store_da_high_resolution,
> 0);
>
> -static ssize_t adt7316_show_AIN_internal_Vref(struct device *dev,
> +static ssize_t adt7316_show_ain_internal_vref(struct device *dev,
> struct device_attribute *attr,
> char *buf)
> {

These are scientific notation. It's like making someone's
name lowercase to satisfy checkpatch. The one rule is more important
than the other rule.

regards,
dan carpenter