Re: [PATCH v2 2/2] arm64: dts: ti: k3-am642-tqma64xxl-mbax4xxl: add icssg1 ti,pa-stats

[Nora Schiffer]

On Mon, 2026-07-13 at 13:06 +0530, Vignesh Raghavendra wrote:
> 
> On 06/07/26 20:13, Nora Schiffer wrote:
> > From: Alexander Feilke <Alexander.Feilke@xxxxxxxxxxxxxxx>
> > 
> > Add missing ti,pa-stats syscon phandle. In addition to providing
> > additional ethtool stats, this avoids a "icssg-prueth icssg1-eth:
> > couldn't get ti,pa-stats syscon regmap" error message.
> > 
> > Signed-off-by: Alexander Feilke <Alexander.Feilke@xxxxxxxxxxxxxxx>
> > [Nora Schiffer: edited commit description]
> > Signed-off-by: Nora Schiffer <nora.schiffer@xxxxxxxxxxxxxxx>
> 
> Does this need a Fixes tag then?

I don't think so - the message was introduced in commit 550ee90ac61c ("net: ti:
icssg-prueth: Add support for PA Stats"), which was then fixed up in commit
9e70eb4a9a8e ("net: ti: icssg-prueth: Make pa_stats optional") to avoid breaking
existing Device Trees. There is no commit that this patch meaningfully "fixes",
and backporting it to stable kernels does not seem necessary to me.

If anything, the message in the driver might be downgraded from "error" to
"warning" in another patch, but I'll leave that decision to you.

Best,
Nora


> 
> > ---
> > 
> > v2: update commit message to correctly describe the error message this
> > avoids.
> > 
> >  arch/arm64/boot/dts/ti/k3-am642-tqma64xxl-mbax4xxl.dts | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/arch/arm64/boot/dts/ti/k3-am642-tqma64xxl-mbax4xxl.dts b/arch/arm64/boot/dts/ti/k3-am642-tqma64xxl-mbax4xxl.dts
> > index 46be6824dd163..b9e52d8bc8524 100644
> > --- a/arch/arm64/boot/dts/ti/k3-am642-tqma64xxl-mbax4xxl.dts
> > +++ b/arch/arm64/boot/dts/ti/k3-am642-tqma64xxl-mbax4xxl.dts
> > @@ -110,6 +110,7 @@ icssg1_eth: icssg1-eth {
> >  		ti,mii-g-rt = <&icssg1_mii_g_rt>;
> >  		ti,mii-rt = <&icssg1_mii_rt>;
> >  		ti,iep = <&icssg1_iep0>,  <&icssg1_iep1>;
> > +		ti,pa-stats = <&icssg1_pa_stats>;
> >  
> >  		ethernet-ports {
> >  			#address-cells = <1>;
> 

-- 
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
https://www.tq-group.com/