Re: [PATCH v1] mm/slub: add comment explaining intentional kobject handling in sysfs_slab_add

[Harry Yoo]

On 7/13/26 4:45 PM, Hongling Zeng wrote:
> 在 2026年07月13日 15:26, Harry Yoo 写道:
>> On 7/13/26 4:00 PM, Hongling Zeng wrote:
>>> Add a comment to clarify why we don't call kobject_put() when
>>> kobject_init_and_add() fails in sysfs_slab_add().
>>>
>>> Per commit 2420baa8e046 ("mm/slab: Allow cache creation to proceed
>>> even if sysfs registration fails"), sysfs failures are treated as
>>> non-fatal and the cache continues to be used. Calling kobject_put()
>>> would trigger slab_kmem_cache_release() which frees the entire
>>> cache structure, so we intentionally skip it.
>>>
>>> Suggested-by: Harry Yoo <harry@xxxxxxxxxx>
>>> Signed-off-by: Hongling Zeng <zenghongling@xxxxxxxxxx>
>>> ---

FWIW, the patch looks fine to me, so:
Acked-by: Harry Yoo (Oracle) <harry@xxxxxxxxxx>

>>>   Change in v1:
>>>   -Correct the email
>>
>> Hmm, the email "Hyeonggon Kim <pictureone@xxxxxxxxx>" came out of
>> nowhere. Could you please explain why this happened?
>   My apologies for the confusion.
> 
>   I incorrectly retrieved your email from a signature search ：）

You mean retrieved from your local address book?

-- 
Cheers,
Harry / Hyeonggon

Attachment: OpenPGP_signature.asc
Description: OpenPGP digital signature