Re: [PATCH] usb: typec: ucsi: Use %pe to print error pointers

[Heikki Krogerus]

On Thu, Jul 09, 2026 at 08:13:33AM +0530, Subasri S wrote:
> Use the %pe format specifier instead of %ld with PTR_ERR() for printing
> error pointers in ucsi_register_plug(), ucsi_register_cable(), and
> ucsi_register_partner(). This prints symbolic error names (e.g.
> -ENOMEM) instead of errno numbers (e.g. -12), making debug logs more
> readable.
> 
> This patch fixes coccinelle reported warnings:
> ./typec/ucsi/ucsi.c:1026:3-10: WARNING: Consider using %pe to print PTR_ERR()
> ./typec/ucsi/ucsi.c:1156:3-10: WARNING: Consider using %pe to print PTR_ERR()
> ./typec/ucsi/ucsi.c:967:3-10: WARNING: Consider using %pe to print PTR_ERR()
> 
> Signed-off-by: Subasri S <subasris1210@xxxxxxxxx>

Reviewed-by: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx>

> ---
>  drivers/usb/typec/ucsi/ucsi.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/usb/typec/ucsi/ucsi.c b/drivers/usb/typec/ucsi/ucsi.c
> index 92166a3725b1..bf896e5cefc3 100644
> --- a/drivers/usb/typec/ucsi/ucsi.c
> +++ b/drivers/usb/typec/ucsi/ucsi.c
> @@ -963,8 +963,8 @@ static int ucsi_register_plug(struct ucsi_connector *con)
>  	plug = typec_register_plug(con->cable, &desc);
>  	if (IS_ERR(plug)) {
>  		dev_err(con->ucsi->dev,
> -			"con%d: failed to register plug (%ld)\n", con->num,
> -			PTR_ERR(plug));
> +			"con%d: failed to register plug (%pe)\n", con->num,
> +			plug);
>  		return PTR_ERR(plug);
>  	}
>  
> @@ -1022,8 +1022,8 @@ static int ucsi_register_cable(struct ucsi_connector *con)
>  	cable = typec_register_cable(con->port, &desc);
>  	if (IS_ERR(cable)) {
>  		dev_err(con->ucsi->dev,
> -			"con%d: failed to register cable (%ld)\n", con->num,
> -			PTR_ERR(cable));
> +			"con%d: failed to register cable (%pe)\n", con->num,
> +			cable);
>  		return PTR_ERR(cable);
>  	}
>  
> @@ -1152,8 +1152,8 @@ static int ucsi_register_partner(struct ucsi_connector *con)
>  	partner = typec_register_partner(con->port, &desc);
>  	if (IS_ERR(partner)) {
>  		dev_err(con->ucsi->dev,
> -			"con%d: failed to register partner (%ld)\n", con->num,
> -			PTR_ERR(partner));
> +			"con%d: failed to register partner (%pe)\n", con->num,
> +			partner);
>  		return PTR_ERR(partner);
>  	}
>  
> 
> ---
> base-commit: dc59e4fea9d83f03bad6bddf3fa2e52491777482
> change-id: 20260708-subasri-usb-ucsi-v1-34dde97e0b61
> 
> Best regards,
> -- 
> Subasri S <subasris1210@xxxxxxxxx>

-- 
heikki