Re: [PATCH v2] powerpc/ps3: Remove unused struct table in setup_areas()

[Amit Machhiwal]

On 2026/07/13 11:17 AM, Thorsten Blum wrote:
> The local table structure is not used - remove it.
> 
> Reviewed-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> Signed-off-by: Thorsten Blum <thorsten.blum@xxxxxxxxx>
> ---
> Changes in v2:
> - Drop the %0 change because it is valid kernel-doc markup (Amit)

Thanks for addressing the comment and sending a v2!

Reviewed-by: Amit Machhiwal <amachhiw@xxxxxxxxxxxxx>

~Amit

> - v1: https://lore.kernel.org/r/20260712151300.3664-3-thorsten.blum@xxxxxxxxx/
> ---
>  arch/powerpc/platforms/ps3/spu.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/arch/powerpc/platforms/ps3/spu.c b/arch/powerpc/platforms/ps3/spu.c
> index e817def7f424..2c785bc72565 100644
> --- a/arch/powerpc/platforms/ps3/spu.c
> +++ b/arch/powerpc/platforms/ps3/spu.c
> @@ -190,8 +190,6 @@ static void spu_unmap(struct spu *spu)
>  
>  static int __init setup_areas(struct spu *spu)
>  {
> -	struct table {char* name; unsigned long addr; unsigned long size;};
> -
>  	spu_pdata(spu)->shadow = ioremap_prot(spu_pdata(spu)->shadow_addr,
>  					      sizeof(struct spe_shadow),
>  					      pgprot_noncached_wc(PAGE_KERNEL_RO));